No scripted fields for significant_terms#8723
No scripted fields for significant_terms#8723spalger wants to merge 6 commits intoelastic:masterfrom
Conversation
f2bb94f to
db85192
Compare
src/ui/public/vis/agg_config.js
Outdated
There was a problem hiding this comment.
What's the reason for removing the conditional here? This seems to alter the flow of the loop so that if there are no indexedFields only the first param will ever be rendered, whereas before all params up to the field param would be rendered.
There was a problem hiding this comment.
The behavior you were seeing was a symptom of the error fixed in eaf5f1636fbebcca0b923de48576d84611ac8582.
This motivation for this change was preventing the aggParams directive from needing to know which params might need the indexedFields. As I say it though, I realize that every param for an aggConfig that has a field param is now getting indexedFields, because we are breaking out of the param and asking the agg for its fieldOptions. My mistake.
d1a7f94 to
4e15f39
Compare
ac70791 to
c5d6a91
Compare
f684a3b to
657e157
Compare
657e157 to
0e11c22
Compare
|
Merging into #8734 |

Builds on top of #8734